chore(linux): improve compatibility with Gentoo Linux 🏠 #12889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
keymanapp-test-bot
bot
changed the title
ermshiperete
force-pushed
the
chore/linux/gentoo-compatibility
branch
2 times, most recently
from
8782634 to
4f65a41
Compare
ermshiperete
force-pushed
the
chore/linux/gentoo-compatibility
branch
from
4f65a41 to
52f3d4f
Compare
Gentoo doesn't use systemd. `libelogind` or `basu` implement some aspects of systemd, so we use that on Gentoo (or rather when `libsystemd` is not available but `libelogind` or `basu` is). Patch from https://forums.gentoo.org/viewtopic.php?p=8850566. See also https://community.software.sil.org/t/keyman-for-gentoo-linux/9615.
ermshiperete
force-pushed
the
chore/linux/gentoo-compatibility
branch
from
52f3d4f to
76206c6
Compare
darcywong00
reviewed
Jan 28, 2025
| # Gentoo can use libelogind or basu | ||
| systemd = dependency('basu') | ||
| conf.set('DBUS_IMPLEMENTATION', 'BASU') | ||
| endif |
There was a problem hiding this comment.
Is there a failure if none of these are available?
There was a problem hiding this comment.
Yes, the dependency function has an implicit required: true parameter. But probably good to add it anyways to make it clearer.
`required: true` is the default for the meson `dependency` function, but it's easy to miss.
ermshiperete
added a commit
that referenced
this pull request
Jan 29, 2025
Gentoo doesn't use systemd. `libelogind` or `basu` implement some aspects of systemd, so we use that on Gentoo (or rather when `libsystemd` is not available but `libelogind` or `basu` is). Patch from https://forums.gentoo.org/viewtopic.php?p=8850566. See also https://community.software.sil.org/t/keyman-for-gentoo-linux/9615. Cherry-pick-of: #12889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gentoo doesn't use systemd.
libelogindorbasuimplement some aspects of systemd, so we use that on Gentoo (or rather whenlibsystemdis not available butlibelogindorbasuis).Patch from https://forums.gentoo.org/viewtopic.php?p=8850566.
See also https://community.software.sil.org/t/keyman-for-gentoo-linux/9615.
@keymanapp-test-bot skip